Alchemy: Not a lot to say about Alchemy - the single most important thing to note is that you *need* to have rank 3 recipes to even think about making gold with this profession. In addition to that you *need* to have the tools of the trade for the extra proc chance. Alchemy hasn't been as profitable for me as it was in Legion, but some specific potions that always sold well were:
Lightfoot Potion,
Empowered Proximity,
Focused Resolve and
Unbridled Fury. I'd usually always make a profit on these. There are some old expansion crafts that are good as well, such as the
Draenic Invisibility Potion. As for Flasks I only crafted the Greater Flasks for Strength, Agility and Intellect as they sold well and the profit margins weren't high enough to where I wanted to sit on these for too long. Make sure to sell these on reset day. The price will usually be highest and the demand likewise. One thing I did was make sure most of my characters had alchemy as one of their professions, and if you have many characters I'd suggest the same. I did the
daily anchor weed cool down on 7 characters, which was an easy 5k profit every day from 5 minutes of work.
Blacksmithing: During 8.2 I crafted Notorious gear, during 8.3 I crafted Uncanny gear. Not much to say, apart from the fact that they sell, and they sell very well. Some examples:
Uncanny Combatant's Cutlass: 24 sold, 130k total gold.
Deckpounder. 9 sold, 65k total gold.
Spellblade: 10 sold, 41k total gold. Apart from that I also crafted
Monel-Hardenes Hoofplates and
Monel-Hardened Stirrups whenever profitable, a total gold of 110k. Lastly as I mentioned earlier, the part for
Xiwyllag ATV - I crafted and sold both the mount and the separate parts to maximize my profits from these items. They are dirt cheap to make and sell for 100%+ profits.
Cooking: The only thing I did with cooking was spend my leftover spare parts from my time in Mechagon to craft
F.E.A.S.T.S and
Big-Mechs. The profits are insane, and the spare part farm is still a great way to make gold if you enjoy farming mats. The best time to sell these is obviously closer to the weekly reset/raid times, but whenever the feasts were above 2.5k I just listed them. There was definitely more potential here, I was just too lazy.
Enchanting: Another profession where the tools of the trade is mandatory. It gives you extra resources when disenchanting which is big, especially if you do the bracer shuffle. I didn't have much success with the wand, so I probably wouldn't make this a priority in terms of recipe ranks (Medal of Honor farm). Ring enchants and weapon enchants sold really well, though. I could've made more profits with this expansion, but I never bought a single mat for this profession. All the mats I used were from mana pearls (emissaries across multiple characters), the bracer shuffle and the odd items I would get on my enchanter. The 450k I made in enchant sales was "pure profit", in the sense that it was all made with mats I got from the expulsion crafting or for minimal effort. I'd recommend you also look into the sale rate of the Tome of Illusions from prior expansions. There are some you have to go out of your way to farm, but these usually have pretty decent profits and sale rates. It's one of the only old expansion crafts I focused on, and I made 150k in sales, at somewhere around 150% profit on average across all illusions.
Engineering: I don't think I fully utilized the potential of Engineering, as I ignored all old world crafts. I know the old engineering mounts used to sell very well, even though they are engineer-only. I'd look into that, but when I went over most of these old crafts the profits didn't seem high enough for me given that I wanted to minimize my time played. As I said earlier, I made and sold quite a few
Mecha-Mogul mounts, but I wouldn't do it again knowing the current price. It's up to you depending on how much you enjoy farming. I also made and sold the
Xiwyllag ATV part alongside the mount. I only had one sale, but it was at 38k gold - more than the mount sells for. The takeaway from this is to always list mats and the final product if you can, as no matter what sells you're making a profit, and potentially have a better control on the market. Another thing it to never be scared of listing items for too much, sometimes items sell for way too much.
Inscription: The gold-mine of BfA. I missed out on the Darkmoon Deck craziness at launch, but Inscription has kept strong all expansion. The off-hand sells well. I sold 12
uncanny versions in 2 weeks for a total of 79k gold. Don't ignore the craftable gear. The highborne trinkets have also been a good seller. I didn't expect them to sell as well at the end of 8.2, but they did, and they've still sold in 8.3. In total I sold 148 trinkets for a total of 480k gold, at about 200% profit on average. I would buy
Zin'anthid at all times when I saw it under a certain price, so I always had more than enough to craft cheap trinkets. War-scrolls have also been a steady seller, I assume all expansion long. They sell fast and for me it's been at 100g+ profit per scroll - the same goes for Tomes (the Legion tomes also sold well for me). For crimson ink I would usually always buy the cheapest of the original herbs whenever they were below a certain amount. In the end I had so much cheap Zin'anthid and other BfA herbs stocked up that I sold several thousands of it at a huge profit compared to what I bought it for. As for viridescent ink, if you're not opposed to scrapping, Darkmoon trinkets still sell. I decided to make lots of Darkmoon cards with some spare expolsum and viridescent ink, and to my surprise I could sell several of these a week. The profits were minuscule at best, but it was better than vendoring the ink. One last tip for inscription: You will be buying a ton of
Light Parchment. Make a macro . This macro will buy a stack of 200 from the Yak. It'll save you a lot of time and clicks.
Jewelcrafting: A profession often labeled DOA in BfA - 100% untrue. While sockets haven't been the best of money-makers, the crafted staff has been incredible. I sold 10 of the Notorious staves for a total of 168k gold. I've also sold 4 of the Uncanny versions for a total of 91k gold. If you do a shopping scan and buy cheap mats, you'll make insane profits on these staves. The 310 rings have also been a decent seller, but negligible in the grand scheme of things, and with 8.3 they're probably not worth it anymore.
Leatherworking: I don't want to repeat myself too much, so as with Blacksmithing, you can make a lot of gold with the crafted gear. I also made some toys with recipes from past expansions that sold for huge profits, but the time to sell and the amount of substantial undercuts from impatient sellers made me drop these. Drums are a great seller as well, though you may have a hard time getting good profits from the more recent drums as the
WoD drums are still the cheapest, due to the garrison trader. I didn't bother with this, but it's worth looking into if you have a garrison and don't mind going there every now and then.
Tailoring: A must-have profession, if only for the bracer shuffle. If you don't have a tailor yet, get one. Again, the crafted gear sells. Apart from that I focused mainly on bags. With the new allied races coming, I knew bags would sell well. Overall I sold 401
Deep Sea Bags for 186k in total, making around 100g in profit per bag. The
32-slot bags were the real sellers, though. I sold 61 for a total of 397k. The profits have been huge, several thousand per bag since 8.3. What makes these harder to craft is that they require
hydrocores, which is somewhat scarce for obvious reasons. What I'd suggest is if you have a ton of hydrocores/tidalcores on any of your characters, consider switching to tailoring to make profits with these, as I haven't found a better use for them. With tailoring you'll need to buy a ton of
Nylon Thread, so here's another macro I suggest you use . This will buy a stack of 200 from the vendor in Dazar'alor (will work in Boralus as well, assuming it's the first item in the vendor-window).